-
Notifications
You must be signed in to change notification settings - Fork 117
feat(firebase_ui_localizations): Further German translations for auth labels that were still in English #319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@fighterii - Thanks for the PR 😄. Do you have a fellow developer who is fluent in German to double check the translations, please? |
@russellwheatley Unfortunately not. Maybe we have to trust AI here for double-checking :D :D |
Hey @nilsreichardt - what do you think of these German translations? 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Besides the suggestions, LGTM
@nilsreichardt - Thank you! |
Co-authored-by: Nils Reichardt <[email protected]>
Description
Corrected German Translations for Email Verification (which were previously not translated and just in english).
Related Issues
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]
).This will ensure a smooth and quick review process. Updating the
pubspec.yaml
and changelogs is not required.///
).melos run analyze
) does not report any problems on my PR.melos run test:unit:all
doesn't fail).Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?