Skip to content

feat(firebase_ui_localizations): Further German translations for auth labels that were still in English #319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
May 14, 2024

Conversation

fighterii
Copy link
Contributor

Description

Corrected German Translations for Email Verification (which were previously not translated and just in english).

Related Issues

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (melos run analyze) does not report any problems on my PR.
  • All unit tests pass (melos run test:unit:all doesn't fail).
  • I read and followed the Flutter Style Guide.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

@fighterii fighterii changed the title German translation for Email verification style: German translation for Email verification Mar 28, 2024
@fighterii fighterii changed the title style: German translation for Email verification style(firebase_ui_localizations): German translation for Email verification Mar 28, 2024
@russellwheatley russellwheatley changed the title style(firebase_ui_localizations): German translation for Email verification feat(firebase_ui_localizations): German translation for Email verification Apr 12, 2024
@russellwheatley
Copy link
Member

@fighterii - Thanks for the PR 😄. Do you have a fellow developer who is fluent in German to double check the translations, please?

@russellwheatley russellwheatley added the blocked: customer response Waiting for customer response, e.g. more information was requested. label Apr 16, 2024
@fighterii
Copy link
Contributor Author

@russellwheatley Unfortunately not. Maybe we have to trust AI here for double-checking :D :D

@russellwheatley
Copy link
Member

Hey @nilsreichardt - what do you think of these German translations? 😄

Copy link
Contributor

@nilsreichardt nilsreichardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides the suggestions, LGTM

@russellwheatley
Copy link
Member

@nilsreichardt - Thank you!

@russellwheatley russellwheatley changed the title feat(firebase_ui_localizations): German translation for Email verification feat(firebase_ui_localizations): Further German translations for auth labels that were still in English May 14, 2024
@russellwheatley russellwheatley merged commit 2f96686 into firebase:main May 14, 2024
11 of 14 checks passed
@fighterii fighterii deleted the german_translation branch May 14, 2024 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked: customer response Waiting for customer response, e.g. more information was requested.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants